Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161178533 Fix Time to read for articles response #64

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

CEOehis
Copy link
Contributor

@CEOehis CEOehis commented Oct 12, 2018

What does this PR do?

Implement fix to return timeToRead with article response

Any background context you want to provide?

The previous implementation excluded this field.

What are the relevant pivotal tracker stories?

#161178533

@coveralls
Copy link

coveralls commented Oct 12, 2018

Pull Request Test Coverage Report for Build 559

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.597%

Totals Coverage Status
Change from base Build 551: 0.0%
Covered Lines: 2492
Relevant Lines: 2639

💛 - Coveralls

Article,
ArticleCategory,
User
} from '../models';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing file extension for "../models" import/extensions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hound is flagging this as an error. which is fine since we don't add file extensions to file imports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@CEOehis CEOehis force-pushed the bg-fix-time-to-read-161178533 branch from ce8f2c2 to d2e7bd8 Compare October 12, 2018 12:10
Copy link
Contributor

@lauragift21 lauragift21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM 👍

Article,
ArticleCategory,
User
} from '../models';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hound is flagging this as an error. which is fine since we don't add file extensions to file imports.

Copy link
Contributor

@emekafredy emekafredy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iamuchejude iamuchejude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@CEOehis CEOehis added ready and removed not-ready labels Oct 12, 2018
@waleCloud waleCloud merged commit cbfa9cc into develop Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants