-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#161178533 Fix Time to read for articles response #64
Conversation
Pull Request Test Coverage Report for Build 559
💛 - Coveralls |
Article, | ||
ArticleCategory, | ||
User | ||
} from '../models'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "../models" import/extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hound is flagging this as an error. which is fine since we don't add file extensions to file imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
ce8f2c2
to
d2e7bd8
Compare
d2e7bd8
to
bf4b43f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM 👍
Article, | ||
ArticleCategory, | ||
User | ||
} from '../models'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hound is flagging this as an error. which is fine since we don't add file extensions to file imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
What does this PR do?
Implement fix to return
timeToRead
with article responseAny background context you want to provide?
The previous implementation excluded this field.
What are the relevant pivotal tracker stories?
#161178533