Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update muscle and exercise lists #22

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Conversation

hariclerry
Copy link

What does this PR do?

There are already lists of muscles and exercises in the system, so this PR updates or adds more data to the existing data.

Description of Task to be completed?

Update list of available muscles as well as the exercises.

How should this be manually tested?

  1. Follow the setup instructions in README.rst
  2. Run the python manage.py runserver command to start the app.
  3. Log in as an admin with default username: admin and default password: admin.
  4. From the dashboard, click on the Exercises tab, from the drop down menu click on the muscle overview link.
  5. From the overview page you should be able to see list of muscles with the new added muscles, hover over the muscles to see the list of exercises added to them.

Screen Shots

Page showing Muscle1 overview and list of exercises

muscle1

Page showing Muscle2 overview and list of exercises

muscle2

Any background context you want to provide?

New muscles added are:

  1. Lateral deltoid
  2. Posterior Deltoid
  3. Forearms
  4. Erector spinae. This muscle already existed in the muscle lists but didn't have an SVG image and exercises. So I added an SVG image and lists of exercises to it.

What are the relevant pivotal tracker stories?

#157731621

@hariclerry
Copy link
Author

Hey guys, can you please review my PR and let me know what you think.

@coveralls
Copy link

coveralls commented Jun 19, 2018

Pull Request Test Coverage Report for Build 343

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.079%

Totals Coverage Status
Change from base Build 319: 0.0%
Covered Lines: 12426
Relevant Lines: 13350

💛 - Coveralls

@dondrzzy
Copy link

@hariclerry , good stuff. Make sure you incoporate the hover over those muscles on the image and display the exercises. Add the paths to the svg in muscles.js. Back muscles to musclesBack and front muscles to musclesFront oterwise, its okay.

This commit updates or adds more muscles and exercises
into the system by updating the Json data files

Currently, there are already lists of muscles and exercises in the system,
this commit adds more data to the existing data.

[Delivers #157731621]
@hariclerry hariclerry force-pushed the ft-update-muscle-list-157731621 branch from ae680e0 to acef6b6 Compare June 20, 2018 07:40
@hariclerry
Copy link
Author

@dondrzzy, I have incorporated the hover over for muscles. The exercises were already added. Thanks for your help with muscle hovering over effects.

@hariclerry hariclerry changed the title feat(update-muscle) Update muscle and exercise lists Update muscle and exercise lists Jun 20, 2018
@hariclerry hariclerry added the ready Used for PRs that your feel are completed and ready to be merged. label Jun 20, 2018
@emugaya emugaya merged commit d9c8ec7 into develop Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Used for PRs that your feel are completed and ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants