Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159236214 Fix a redirect bug. #16

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Conversation

ja-odur
Copy link
Contributor

@ja-odur ja-odur commented Aug 10, 2018

What does this PR do?

  • Fixes a redirect bug

Description of Task to be completed?

  • Fix the redirect bug that occurs due to the reference Gym id not being found in the database

How should this be manually tested?

  • Clone this branch and follow the instructions stated in README to set up the application.
  • After setting up the application, start the server by running the command python manage.py runserver in the terminal with your virtual environment set.
  • In the browser, log in as an Admin and go to the gyms page. As an admin or a gym manager, you should be able to delete, deactivate and re-activate users as shown in the screenshots section.

Screenshots

screen shot 2018-08-10 at 10 34 37

@ja-odur ja-odur force-pushed the ft-allow-deleting-trainers-159236214 branch from c57d02a to cc90c3a Compare August 10, 2018 07:55
Copy link
Contributor

@Yiga-fred Yiga-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ja-odur the bug is fixed but the PR shows a lot of file changes, I suggest you only include what is related to the bug fix.

@ja-odur ja-odur force-pushed the ft-allow-deleting-trainers-159236214 branch from cc90c3a to 6abcae3 Compare August 10, 2018 08:36
Copy link
Contributor

@Yiga-fred Yiga-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solnsubuga
Copy link
Contributor

@ja-odur the commit message is misleading. Please use one that is descriptive of the bug you have fixed.

@ja-odur ja-odur force-pushed the ft-allow-deleting-trainers-159236214 branch from 6abcae3 to 4ebf53c Compare August 10, 2018 08:43
@ja-odur
Copy link
Contributor Author

ja-odur commented Aug 10, 2018

@solnsubuga @Yiga-fred I have worked on the comments you gave.

@coveralls
Copy link

coveralls commented Aug 10, 2018

Pull Request Test Coverage Report for Build 311

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 35 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.3%) to 92.952%

Files with Coverage Reduction New Missed Lines %
wger/exercises/tests/test_categories.py 1 100.0%
wger/manager/views/set.py 1 96.33%
wger/manager/forms.py 2 100.0%
wger/exercises/tests/test_muscles.py 3 100.0%
wger/exercises/tests/test_equipment.py 3 100.0%
wger/exercises/tests/test_exercise.py 6 100.0%
wger/utils/widgets.py 19 97.4%
Totals Coverage Status
Change from base Build 309: -0.3%
Covered Lines: 12265
Relevant Lines: 13195

💛 - Coveralls

@solnsubuga
Copy link
Contributor

LGTM

 * fixed the invalid gym id passed to the redirected url after deleting of deactivating a trainer account.
@ja-odur ja-odur force-pushed the ft-allow-deleting-trainers-159236214 branch from 4ebf53c to 5a97d0f Compare August 13, 2018 08:15
@lym lym merged commit 9493cd0 into develop Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants