-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#159236214 Fix a redirect bug. #16
Conversation
c57d02a
to
cc90c3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ja-odur the bug is fixed but the PR shows a lot of file changes, I suggest you only include what is related to the bug fix.
cc90c3a
to
6abcae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ja-odur the commit message is misleading. Please use one that is descriptive of the bug you have fixed. |
6abcae3
to
4ebf53c
Compare
@solnsubuga @Yiga-fred I have worked on the comments you gave. |
Pull Request Test Coverage Report for Build 311
💛 - Coveralls |
LGTM |
* fixed the invalid gym id passed to the redirected url after deleting of deactivating a trainer account.
4ebf53c
to
5a97d0f
Compare
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
python manage.py runserver
in the terminal with your virtual environment set.gyms
page. As an admin or a gym manager, you should be able to delete, deactivate and re-activate users as shown in the screenshots section.Screenshots