Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# 166185735 Allow comparison of members #23

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Emmanuel-Dominic
Copy link
Contributor

@Emmanuel-Dominic Emmanuel-Dominic commented Jun 13, 2019

What does this PR do?

  • Allow comparison of members

Description of Task to be completed?

  • When two users are training together it would be useful to see a comparison of some sorts. A possibility would be to have a graph where the data for (selected) members is shown or, less nicely, at least have different graphs under each other.
  • However there are other ways of comparing data besides the graph that could be explored. You are encouraged to get creative here in case you don't go with the suggestion above.

How should this be manually tested?

  • Added different users weights into the system plus your person weights for different days, then access the page for compare user weight entry at the menu under the weight drop down.
  • The comparison is between the logged in user and the user whose username is provided in the search field.
  • Provided Link to the page

Screenshot 2019-06-18 at 10 36 58

What are the relevant pivotal tracker stories?

Screenshots

Screenshot 2019-06-17 at 22 02 31

@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch 2 times, most recently from b1cf5df to 89b8517 Compare June 13, 2019 17:22
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 14, 2019 08:29 Inactive
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 14, 2019 08:43 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 89b8517 to 8d9bd48 Compare June 14, 2019 08:59
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 14, 2019 08:59 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 8d9bd48 to 772f66f Compare June 14, 2019 22:50
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 14, 2019 22:50 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 772f66f to aa064b5 Compare June 15, 2019 05:46
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 15, 2019 05:47 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from aa064b5 to 12e37eb Compare June 17, 2019 18:25
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 17, 2019 18:26 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 12e37eb to b8c807a Compare June 17, 2019 18:43
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 17, 2019 18:43 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from b8c807a to 91923b6 Compare June 17, 2019 18:49
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 17, 2019 18:50 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 91923b6 to 15d0eda Compare June 17, 2019 19:00
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 17, 2019 19:00 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 15d0eda to 9dc52d0 Compare June 17, 2019 19:07
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 17, 2019 19:07 Inactive
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 9dc52d0 to 1ebc391 Compare June 18, 2019 07:26
@Emmanuel-Dominic Emmanuel-Dominic temporarily deployed to wger-kronos-pr-23 June 18, 2019 07:26 Inactive
@Emmanuel-Dominic Emmanuel-Dominic added Review Required Requires teammates review and removed wip labels Jun 18, 2019
@Emmanuel-Dominic Emmanuel-Dominic requested review from Rhytah and reifred and removed request for Rhytah and reifred June 18, 2019 07:44
Copy link
Contributor

@reifred reifred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Emmanuel-Dominic for the work done. KIndly follow coding conventions by using a single commit. In addition work on some slight changes as mentioned below.

wger/urls.py Outdated Show resolved Hide resolved
wger/urls.py Show resolved Hide resolved
startup Outdated Show resolved Hide resolved
wger/weight/urls.py Show resolved Hide resolved
wger/weight/views.py Outdated Show resolved Hide resolved
wger/weight/views.py Outdated Show resolved Hide resolved
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from fdc5fae to 61b0296 Compare June 19, 2019 13:38
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 61b0296 to 22726dc Compare June 19, 2019 16:05
@Emmanuel-Dominic Emmanuel-Dominic added the Done Finished tast label Jun 20, 2019
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 22726dc to 9864280 Compare June 20, 2019 13:54
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 9864280 to 6aef304 Compare June 20, 2019 14:05
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 6aef304 to 5ffe270 Compare June 20, 2019 14:59
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 5ffe270 to 825cc03 Compare June 20, 2019 16:48
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 825cc03 to 066d9fb Compare June 20, 2019 18:59
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 066d9fb to 88a0819 Compare June 20, 2019 19:39
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 88a0819 to 62d2573 Compare June 20, 2019 19:56
@Emmanuel-Dominic Emmanuel-Dominic force-pushed the ft-allow-comparison-of-members-166185735 branch from 34cb746 to 9d69d53 Compare June 20, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Finished tast Review Required Requires teammates review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants