feat: Adds communication_disabled_until to support user timeouts #474
Conversation
| Roles []Snowflake `json:"roles"` | ||
| JoinedAt Time `json:"joined_at,omitempty"` | ||
| PremiumSince Time `json:"premium_since,omitempty"` | ||
| CommunicationDisabledUntil Time `json:"communication_disabled_until"` |
There was a problem hiding this comment.
To me this makes more sense to be *Time as the field can be null, but it looks like other nullable time fields like PremiumSince do this, so am following that behaviour.
| @@ -123,6 +123,8 @@ type UpdateMember struct { | |||
| Mute *bool `json:"mute,omitempty"` | |||
| Deaf *bool `json:"deaf,omitempty"` | |||
| ChannelID *Snowflake `json:"channel_id,omitempty"` | |||
| // CommunicationDisabledUntil defines when the user's timeout will expire and the user will be able to communicate in the guild again (up to 28 days in the future) | |||
| CommunicationDisabledUntil *Time `json:"communication_disabled_until,omitempty"` | |||
There was a problem hiding this comment.
One caveat is as we use omitempty, you can't set this field to null from what I can tell to remove a users timeout. Perhaps the Time struct could be extended to support returning null in MarshalJSON when you set something like Time.Null = true instead of returning an empty string if you set the time to zero: https://github.com/andersfylling/disgord/blob/master/struct.go#L85-L88
There was a problem hiding this comment.
Do you want to throw up a tests to show this behavior? A simple unit table tests or something.
There was a problem hiding this comment.
I added a unit test to show it as TestUpdateMemberParams 👍
aidenwallis
changed the title
|
Nice work, and good catch on the Time struct. It should be updated indeed! |
Description
Adds support for user timeouts using
communication_disabled_untilfield on guild member objects.https://discord.com/developers/docs/resources/guild#guild-member-object
https://discord.com/developers/docs/resources/guild#modify-guild-member
Breaking Change?
no
Checklist: