forked from zulip/zulip
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
message_list: Don't split message groups for a date divider.
This adds date dividers within a single message group when the only reason we had previously been splitting apart two message groups is a change of date. The overall effect is a cleaner message list user experience. The downside of this change would be that the recipient bars no longer will always show a new date for date changes; to fix that, we rewrite how the floating recipient bars both set the date field on the floating recipient bar itself, as well as ensure that non-floating recipient bars don't show duplicate dates. In a future design update where we modify how message recipient bars look, we may very well be able to simplify this logic by removing some of the dynamic nature of the recipient bar calculations. But this is a good implementation of what remains. Tweaked significantly by tabbott from Steve Howell's original, both to extract these changes from a larger PR as well as to modify the first_visible_message logic to handle some tricky corner cases. Fixes zulip#10171.
- Loading branch information
Showing
5 changed files
with
357 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.