Fix some deprecated code #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y::getInstance() Fixes the following TYPO3v11 deprecation notice: > TYPO3 Deprecation Notice: > TYPO3\CMS\Core\Resource\Index\ExtractorRegistry::getInstance() > will be removed in TYPO3 v12.0. > Use Dependency Injection or GeneralUtility::makeInstance() > if DI is not possible. See: https://docs.typo3.org/c/typo3/cms-core/11.5/en-us/Changelog/11.5/Deprecation-95326-VariousGetInstanceStaticMethodsOnSingletonInterfaces.html
|
TYPO3_REQUEST is not available on CLI. That needs to be checked as well. |
.. and replace it with ApplicationType::isBackend()/isFrontend(). This class has been backported to TYPO3v10 and is available since TYPO3 v10.4.11 https://docs.typo3.org/c/typo3/cms-core/11.5/en-us/Changelog/11.0/Deprecation-92947-DeprecateTYPO3_MODEAndTYPO3_REQUESTTYPEConstants.html
.. GeneralUtility::isFirstPartOfStr() is deprecated in TYPO3v12 https://docs.typo3.org/c/typo3/cms-core/11.5/en-us/Changelog/11.5/Deprecation-95257-GeneralUtilityisFirstPartOfStr.html
|
CLI is handled now. |
This was referenced May 19, 2023
weakbit
approved these changes
May 25, 2023
Kanti
approved these changes
May 25, 2023
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. while keeping compatibility with TYPO3 v10.4.11+
This obsoletes #109, #112 and #117.