Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IN (Fix) - Desbloqueo de cama duplicado #2804

Merged
merged 2 commits into from
Jan 19, 2023
Merged

IN (Fix) - Desbloqueo de cama duplicado #2804

merged 2 commits into from
Jan 19, 2023

Conversation

negro89
Copy link
Contributor

@negro89 negro89 commented Jan 10, 2023 •
edited
Loading

Requerimiento

https://proyectos.andes.gob.ar/browse/IN-517
https://proyectos.andes.gob.ar/browse/IN-516

Funcionalidad desarrollada

(En sidebar para bloqueo/desbloqueo de camas)

  1. Se quitan etiquetas con clases row y col
  2. Se agrega control para no guardar con campos requeridos incompletos
  3. Se oculta el botón 'editar' si la cama esta bloqueada

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@negro89 negro89 requested review from a team as code owners January 10, 2023 12:20
@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8236
CYPRESS RUN: 7420
TEST START: 2023-01-10T12:29:48.752Z
TOTAL: 406
SUCCESS: 390
FAIL: 14
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8237
CYPRESS RUN: 7421
TEST START: 2023-01-10T12:52:33.863Z
TOTAL: 406
SUCCESS: 404
FAIL: 0
SKIPPED: 2

@silviroa silviroa added test ok Los test estan ok and removed test fail labels Jan 10, 2023
@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8243
CYPRESS RUN: 7424
TEST START: 2023-01-11T16:11:30.049Z
TOTAL: 406
SUCCESS: 390
FAIL: 14
SKIPPED: 2

@silviroa silviroa added test fail and removed test ok Los test estan ok labels Jan 11, 2023
@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8244
CYPRESS RUN: 7425
TEST START: 2023-01-11T17:49:27.529Z
TOTAL: 406
SUCCESS: 404
FAIL: 0
SKIPPED: 2

@silviroa silviroa added test ok Los test estan ok and removed test fail labels Jan 11, 2023
@negro89 negro89 force-pushed the IN-517 branch 3 times, most recently from ac42672 to 797e26c Compare January 16, 2023 17:42
MCele
MCele reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@MCele MCele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realicé algunas pruebas y al generar el desbloqueo de una cama no veo que el dato del campo
extras :{ desbloqueo: true } quede asentado en el movimiento de disponible en la bd. Segun noté el patch que modifica (agrega) el estado de la cama no envía esos datos.

@negro89 negro89 force-pushed the IN-517 branch 2 times, most recently from 4379775 to f7b8279 Compare January 19, 2023 15:41
@negro89
Copy link
Contributor Author

negro89 commented Jan 19, 2023

realicé algunas pruebas y al generar el desbloqueo de una cama no veo que el dato del campo extras :{ desbloqueo: true } quede asentado en el movimiento de disponible en la bd. Segun noté el patch que modifica (agrega) el estado de la cama no envía esos datos.

@MCele, ese dato se agrega en esta linea: 74058e0#diff-847a2a8b93e916c792fb0580844befe09210896e7bf01c3369efcbc5d57d17d3R92

Ya se corrigieron los errores que lanzaba por consola 👍🏼

@MCele MCele self-requested a review January 19, 2023 16:12
@MCele MCele merged commit 22fc961 into master Jan 19, 2023
@MCele MCele deleted the IN-517 branch January 19, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCele MCele MCele approved these changes

@MarianoCampetella MarianoCampetella MarianoCampetella approved these changes

@ma7payne ma7payne Awaiting requested review from ma7payne ma7payne is a code owner automatically assigned from andes/code-review

@silviroa silviroa Awaiting requested review from silviroa

Assignees
No one assigned
Labels
test ok Los test estan ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@negro89 @silviroa @MCele @MarianoCampetella