(FEAT) Demanda Insatisfecha: pasar funcionalidad a API #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negro89
requested changes
May 6, 2024
| @@ -53,7 +53,7 @@ export class demandaInsatisfechaComponent { | |||
|
|
|||
| guardar() { | |||
| if (this.motivo && this.tipoPrestacion) { | |||
| if (this.serviceListaEspera.guardar(this.paciente, this.tipoPrestacion, this.estado, this.profesional, this.organizacion, this.motivo.nombre, this.origen)) { | |||
| if (this.listaEsperaService.save(this.paciente, this.tipoPrestacion, this.estado, this.profesional, this.organizacion, this.motivo.nombre, this.origen)) { | |||
There was a problem hiding this comment.
El problema de hacer esto (entiendo que ya estaba así) es que la respuesta del save es asincrona, es decir, lo que retorna es una promesa y recien a la vuelta de la api se obtiene el valor. Por lo tanto el if en primera instancia siempre va a dar true.
Lo correcto sería eliminar el if y dejar solo el llamado y, a la vuelta del subscribe, segun sea exito o error se muestra el toast correspondiente:
Suggested change
| if (this.listaEsperaService.save(this.paciente, this.tipoPrestacion, this.estado, this.profesional, this.organizacion, this.motivo.nombre, this.origen)) { | |
| this.listaEsperaService.save(this.paciente, this.tipoPrestacion, this.estado, this.profesional, this.organizacion, this.motivo.nombre, this.origen).subscribe(respuesta => { | |
| complete: () => { | |
| *** exito *** | |
| }, | |
| error: () => { | |
| *** error *** | |
| } | |
| }) |
JuanIRamirez
force-pushed
the
CIT-268
branch
2 times, most recently
from
da79787
to
3edb37c
Compare
JuanIRamirez
added
changes done
and removed
changes requested
negro89
approved these changes
Jun 13, 2024
MCele
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/CIT-268
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion