Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #2

Merged
merged 48 commits into from
Oct 6, 2021
Merged

[spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #2

merged 48 commits into from
Oct 6, 2021

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jul 15, 2021 •
edited
Loading

Migrate breakpoints plugin to use the new teardown mechanism

Stacked PR Chain: [spy-plugin-registry-teardown]

PR Title Merges Into
spyder-ide#16012 [spy-plugin-registry-teardown] PR: Add plugin teardown operations to the plugin registry N/A
#1 [spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism spyder-ide#16012
#2 [spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #1
#3 [spy-plugin-registry-teardown] PR: Migrate completions plugin to use the new teardown mechanism #2
#4 [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #3
#5 [spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #4
#6 [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #5
#7 [spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #6
#8 [spy-plugin-registry-teardown] PR: Migrate projects to use the new teardown mechanism #7
#9 [spy-plugin-registry-teardown] PR: Migrate pylint, run and shortcuts to use the new teardown mechanism #8
#10 [spy-plugin-registry-teardown] PR: Migrate statusbar, toolbar and tours to use the new teardown mechanism #9
#11 [spy-plugin-registry-teardown] PR: Migrate variable explorer and working directory to use the new teardown mechanism #10
#12 [spy-plugin-registry-teardown] PR: Add preference page to enable and disable plugins #11

This was referenced Jul 15, 2021
Merged
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch from c846f81 to cc09b3e Compare July 15, 2021 18:05
@andfoy andfoy force-pushed the application_plugin_teardown branch from 3b5a323 to e6a4362 Compare July 15, 2021 19:28
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch from cc09b3e to 03ffab8 Compare July 15, 2021 19:28
This was referenced Jul 15, 2021
Merged
Merged
Merged
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch 2 times, most recently from e75cc14 to 9d5e7eb Compare July 16, 2021 19:13
This was referenced Jul 19, 2021
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch from 9d5e7eb to 91a43c7 Compare August 30, 2021 19:53
@andfoy andfoy force-pushed the application_plugin_teardown branch from 17113af to f1169f7 Compare August 30, 2021 22:00
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch 2 times, most recently from e10861d to f962577 Compare August 31, 2021 17:24
@andfoy andfoy force-pushed the application_plugin_teardown branch from 859475c to 9ac9ac5 Compare August 31, 2021 21:19
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch from f962577 to 357cf66 Compare August 31, 2021 21:19
@andfoy andfoy force-pushed the application_plugin_teardown branch from 9ac9ac5 to 9bb13f4 Compare August 31, 2021 22:35
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch 2 times, most recently from 303c444 to b7d7096 Compare August 31, 2021 22:44
@andfoy andfoy force-pushed the application_plugin_teardown branch from 3568f94 to c49667b Compare August 31, 2021 22:49
@andfoy andfoy force-pushed the breakpoints_plugin_teardown branch 2 times, most recently from 53c9143 to e7a0527 Compare August 31, 2021 22:53
@andfoy andfoy force-pushed the application_plugin_teardown branch from 5d8d642 to cfb79c9 Compare August 31, 2021 23:02
@andfoy
Address review comments
b0a0564
@andfoy
Migrate projects to use the new teardown mechanism
4374df0
@andfoy
Update calls to remove_item_from_application_menu
5fb2c09
@andfoy
Address review comments
d11869c
@andfoy
Address further review comments
94c71be
@andfoy
Minor error correction
7cc999e
@andfoy
Restore sig_stop_completions connection
e3464a1
@andfoy
Migrate pylint, run and shortcuts to use the new teardown mechanism
9f5530f
@andfoy
Remove hard reference to editor in pylint
67a9290
@andfoy
Update calls to remove_item_from_application_menu
3dbe853
@andfoy
Address review comments
ff81fe3
@andfoy
Final review comments
5b2ef7a
@andfoy
Migrate statusbar, toolbar and tours to use the new teardown mechanism
7bae6a5
@andfoy
Update calls to remove_item_from_application_menu
f894e52
@andfoy
Address review comments
258e4cf
@andfoy
Add proper signature to statusbar on_close method
fd5e080
@andfoy
Address review comments
dfd6dc8
@andfoy
Migrate variable explorer and working directory to use the new teardo…
46c110b 
…wn mechanism
@andfoy
Update calls to remove_item_from_application_menu
f3e2225
@andfoy
Apply review comments
ff95626
@andfoy
Remove duplicate on__close
f82445e
@andfoy
Add preference page to enable and disable plugins
cf5beef
@andfoy
Restart Spyder after a plugin is enabled/disabled
5e57da5
@andfoy
Disable also Spyder 4 plugins
3a36062
@andfoy
Fix test_preferences_checkboxes_not_checked_regression
c1ae0d7
@andfoy
Address review comments
b6e8b9f
@andfoy
Always add external plugin metadata
2b643c8
@andfoy andfoy merged commit 9c5cb29 into application_plugin_teardown Oct 6, 2021
@andfoy andfoy deleted the breakpoints_plugin_teardown branch October 6, 2021 19:22
andfoy pushed a commit that referenced this pull request Feb 14, 2022
@rear1019
pyside: Do not pass “None” to QTreeView.setExpanded()
80fb661 
PySide2 crashes otherwise (as of PySide2/Qt 5.15.0):

Received signal 6
#0 0x7fecd2bcea7b base::debug::CollectStackTrace()
#1 0x7fecd299bbaf base::debug::StackTrace::StackTrace()
#2 0x7fecd299bb62 base::debug::StackTrace::StackTrace()
#3 0x7fecd2bcd61e base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7fed08461210 <unknown>
#5 0x7fed0846118b gsignal
#6 0x7fed08440859 abort
#7 0x7fed08119882 fatal_error.lto_priv.0
#8 0x7fed0811989f Py_FatalError
#9 0x7fed03c8c50b SetError_Argument
#10 0x7fed03c5d64e Shiboken::setErrorAboutWrongArguments()
#11 0x7fece240f259 Sbk_QTreeViewFunc_setExpanded
<shortened>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andfoy @ccordoba12