Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes posix ModuleNotFoundError on windows #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Coderx7
Copy link

@Coderx7 Coderx7 commented Jul 18, 2020

Addresses issue #4

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2020

Codecov Report

Merging #5 into master will decrease coverage by 0.57%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master       #5      +/-   ##
===========================================
- Coverage   100.00%   99.42%   -0.58%     
===========================================
  Files            7        7              
  Lines          342      345       +3     
  Branches        62       63       +1     
===========================================
+ Hits           342      343       +1     
- Misses           0        1       +1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
src/scantree/compat.py 92.00% <50.00%> (-8.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b51ca...cd1823f. Read the comment docs.

@andhus
Copy link
Owner

andhus commented Aug 26, 2020

Thanks! I'll just try to add test coverage for this on travis before merging 👍

@andhus
Copy link
Owner

andhus commented Aug 31, 2020

Turns out there were a number of issues running under windows :/ thus I don't want to merge this (indicating it is expected to work after the fix) until tests are passing. Please see (and feel free to help out :D at) #6 and the failing travis build.

@Coderx7
Copy link
Author

Coderx7 commented Sep 1, 2020

Thanks, sure I'll look into it when I'm free

@gaby
Copy link
Collaborator

gaby commented Jan 9, 2022

@Coderx7 Were you able to get back to this?

@Coderx7
Copy link
Author

Coderx7 commented Jan 9, 2022

@gaby unfortunately no, I was extremely busy so completely forgot about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants