This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
Rotate collage images and final collage if needed (Fix #156) #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
Collage creation is setup for landscape images, if we're taking pictures in portrait mode the result doesn't look like expected. To fix that we'll have to rotate the subimages before the real collage creation starts.
Another issue is that some collage layouts are optimized for printing and not for displaying in the gallery. Depending on our subimages orientation we'll now rotate the final collage for a better gallery experience.
Collage subimages on
Our print api, especially with QR-Code, ist also expecting landscape images. Portrait pictures should be rotated before we're going through the printing process.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?