Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Rotate collage images and final collage if needed (Fix #156) #163

Merged
merged 3 commits into from Jan 3, 2021
Merged

Conversation

andi34
Copy link
Owner

@andi34 andi34 commented Dec 30, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

Collage creation is setup for landscape images, if we're taking pictures in portrait mode the result doesn't look like expected. To fix that we'll have to rotate the subimages before the real collage creation starts.

Another issue is that some collage layouts are optimized for printing and not for displaying in the gallery. Depending on our subimages orientation we'll now rotate the final collage for a better gallery experience.

Collage subimages on
Our print api, especially with QR-Code, ist also expecting landscape images. Portrait pictures should be rotated before we're going through the printing process.

What changes did you make? (Give an overview)

  • rotate subimages of collage if needed
  • rotate final collage if needed
  • always print landscape images, rotate image if needed
  • crop subimages of collage by center on 2x4 collage with background

Is there anything you'd like reviewers to focus on?

@andi34 andi34 mentioned this pull request Dec 30, 2020
2 tasks
@andi34 andi34 changed the title Fix/156 Rotate collage images and final collage if needed (Fix/156) Dec 30, 2020
@andi34 andi34 changed the title Rotate collage images and final collage if needed (Fix/156) Rotate collage images and final collage if needed (Fix #156) Dec 30, 2020
Change-Id: I8ea28aec35c1a0277444ee996391e68ceecb47e5
Change-Id: I1dcc7c245b01e13d56a7267ff2c1146b012563aa
Change-Id: Ie8399f6c0573c859baed4daafa53610031d5a378
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant