This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
Collage: Always show image after taken #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I32e756f7da1d9779551e8028f7de338091f792b6
Change-Id: Ieb03f34eee64e5a1b35a97dadfb3059ef279cf03
Change-Id: I094a4cae85b08d6c86c06bdb46df9c55369bee3e
This was
linked to
issues
Jul 7, 2021
andi34
force-pushed
the
feature/collage-improvements
branch
from
b7abc80
to
842df45
Compare
|
Show the Image between Countdowns in fullscreen. Space arround the taken Image are unnecessary. |
|
No, I won't change that by default. But you can use a own custom theme or make your changes here (2nd solution only might cause trouble on updates): https://github.com/andi34/photobooth/blob/dev/src/sass/classic_style.scss#L170 Below the image there'll be a message "Please wait" in future (somehow I forgot to add). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
close Issue Feature: collage: always show image after taken #270
What changes did you make? (Give an overview)
Always show picture on continuous collage before next picture is taken. Make time adjustable image is visible.