This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
Improve/core #369
Merged
Improve/core #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi34
force-pushed
the
improve/core
branch
4 times, most recently
from
ce0d812
to
d01d389
Compare
Let's start the picture process from beginning on retry. This saves some lines of code and also start all previews like defined at countdown with one limitation: gphoto preview without bsm needs to be adjusted on a follow up commit, currently it's not started again on retry / next collage image. Retry notification will be visible for 2 seconds until it starts the new countdown. Change-Id: I3d6e40b5b8ebc7fc6715f528ab38835ffd0255d5
…bled Change-Id: I90b34965ae15a29ce3f65ed8f2245105c7651263
The timeout should not be a new countdown, it should be a timeout as it's name says. Change-Id: I46161bfc936a60baa51b9b312c05d74cb3365ea5
Change-Id: I0f7c32d17817ef6528ce9223f7c58994df6fffec
Change-Id: Ib47149b07c9ae187ba9ffbc58efd9c3e035541a0
We can draw an image from the gphoto preview we've got. Image quality won't be good, but it's an option we should give to users. Change-Id: Ie251857185357da3b2bebc74e828e12c1699c835
Let's "clean" api.takePic function while using a own function to stop preview used at countdown and capture an image from preview if needed. Change-Id: I0187318a19c89f0f987767bcd1545d703090251b
Move preview related code for countdown to api.startVideo function. Change-Id: I0d331e125538d7719c1f1bad506658a33f064ce8
Change-Id: I1fbac4a2a2429e6c4b2d4e7b6457cfa8806d6f9c
Preview as background can only be used if preview by device cam or by gphoto is enabled. Change-Id: I4449da664c78588bc69360b9dbdeb49f101508b9
sendMail class selector was already added but not used in all places where possible, let's fix that. Change-Id: If868ddda06c8ff5f9b36e88878e4b86c7d6bddff
Change-Id: Ib23600739ba3b0d6b76f936c5ccfcbbd2ecf565b
Log to console from api.errorPic funtion. Change-Id: I579c57b53b25010478d73c289d8bc2273be26665
Change-Id: I289dbe76b9289261bb706f419ffafb2c41bd2bc0
Change-Id: Iccfb83392dcbc2241d835d7da41cc3126c4c75ef
Change-Id: I4ca28d388e729642a8bbe685b3d49d7fd129ad62
Time settings should be defined once as constant. Change-Id: I25623fcd819d0cdc0e21511cb577bbb03fa31474
|
@up-87 what do you think? IMO good to go. |
|
Did a code review and looks really good. I didn't do any check if everything still works but I didn't notice any obvious error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
Bug fix:
The timeout should not be a new countdown, it should be a timeout as it's name says. Retry notification will now be visible for defined time. Countdown for picture/next collage image is not touched and will be used as defined.
Other, please explain:
This saves some lines of code and also start all previews like defined at countdown.
flip-horizontalclass for preview if needed on api.resetWhat changes did you make? (Give an overview)
See above.
Is there anything you'd like reviewers to focus on?