Replace remove with list comprehension on sql.py

Help performance for #62, #135
andialbrecht · Jun 11, 2016 · 50de51a · 50de51a · vmuriart · Jun 12, 2016
1 parent 9989792
commit 50de51a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/sqlparse/sql.py b/sqlparse/sql.py
@@ -294,7 +294,9 @@ def group_tokens(self, grp_cls, tokens, skip_ws=False, extend=False):
 
         for token in tokens:
             token.parent = grp
-            self.tokens.remove(token)
+
+        # Improve performance. LOOP(list.remove()) is O(n**2) operation
+        self.tokens = [token for token in self.tokens if token not in tokens]
 
         self.tokens.insert(idx, grp)
         grp.parent = self