Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RETURNING keyword #267

Merged
merged 1 commit into from
Jun 25, 2016
Merged

Add RETURNING keyword #267

merged 1 commit into from
Jun 25, 2016

Conversation

darikg
Copy link
Contributor

@darikg darikg commented Jun 24, 2016

Postgresql has a keyword RETURNING used in insert/update/delete commands

@coveralls
Copy link

coveralls commented Jun 24, 2016

Coverage Status

Coverage remained the same at 97.334% when pulling 02e9bf9 on darikg:returning into 78fb204 on andialbrecht:master.

@coveralls
Copy link

coveralls commented Jun 24, 2016

Coverage Status

Coverage remained the same at 97.334% when pulling 02e9bf9 on darikg:returning into 78fb204 on andialbrecht:master.

@coveralls
Copy link

coveralls commented Jun 24, 2016

Coverage Status

Coverage remained the same at 97.334% when pulling 02e9bf9 on darikg:returning into 78fb204 on andialbrecht:master.

@codecov-io
Copy link

Current coverage is 96.10%

Merging #267 into master will decrease coverage by 1.22%

@@             master       #267   diff @@
==========================================
  Files            21         21          
  Lines          1388       1388          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1351       1334    -17   
- Misses           37         54    +17   
  Partials          0          0          

Powered by Codecov. Last updated by 78fb204...79793b7

@codecov-io
Copy link

codecov-io commented Jun 24, 2016

Current coverage is 97.33%

Merging #267 into master will not change coverage

@@             master       #267   diff @@
==========================================
  Files            21         21          
  Lines          1388       1388          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1351       1351          
  Misses           37         37          
  Partials          0          0          

Powered by Codecov. Last updated by 78fb204...02e9bf9

@darikg
Copy link
Contributor Author

darikg commented Jun 24, 2016

Took me a couple tries to get this right bc I kept screwing up alphabetical order 😝

@vmuriart
Copy link
Contributor

scared me for a minute with that 1.22% coverage drop.
I'm not familiar with Postgresql, any concerns or possibility of returning(...) to be parsed as a function? I'm not even sure if that's valid syntax on postgresql

@darikg
Copy link
Contributor Author

darikg commented Jun 25, 2016

It doesn't use function syntax. It looks like this:

INSERT INTO foo (x, y) VALUES (1, 2, 3) RETURNING x, z
or DELETE FROM foo WHERE bar > 3 RETURNING baz, qux

@vmuriart vmuriart merged commit 0e2636d into andialbrecht:master Jun 25, 2016
@vmuriart
Copy link
Contributor

cool, just wanted to check. thanks! - i merged the pr

ovr pushed a commit to cube-js/sqlparse that referenced this pull request Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants