Issue 190 #279
Issue 190 #279
Conversation
|
Coverage decreased (-1.1%) to 96.201% when pulling 9474db4b752f57c732f9c1e4f2babd62ea45ce66 on phdru:issue-190 into b7e6ce7 on andialbrecht:master. |
|
Coverage increased (+0.01%) to 97.348% when pulling 02c29dc8f14d4495e06ab1cb6bcc2802943d63a8 on phdru:issue-190 into b7e6ce7 on andialbrecht:master. |
Current coverage is 97.34% (diff: 100%)@@ master #279 diff @@
==========================================
Files 21 21
Lines 1390 1394 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1353 1357 +4
Misses 37 37
Partials 0 0
|
| @@ -20,6 +20,13 @@ | |||
| from sqlparse.utils import consume | |||
|
|
|||
|
|
|||
| try: | |||
| file | |||
There was a problem hiding this comment.
whats the purposed of this line ?
|
Can you add a couple tests here as well |
|
To distinguish Python2 and Python3: $ python3
Python 3.4.2 (default, Oct 8 2014, 13:14:40)
[GCC 4.9.1] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> file
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'file' is not defined |
|
Wouldn't the next line do the same thing? It should still raise the same Exception (never tried it though) |
|
Oh, yes. 😄 |
|
Coverage increased (+0.008%) to 97.346% when pulling dd0581c62a746ec790ebad77e15ae7485dc3884e on phdru:issue-190 into b7e6ce7 on andialbrecht:master. |
1 similar comment
|
Done. Fixed and added a test. All tests passed. |
|
Thanks for the pr! |
Fix #190.