Skip to content

Commit

Permalink
[yamahamusiccast] Add discovery information (openhab#16231)
Browse files Browse the repository at this point in the history
* [yamahamusiccast] Add discovery information

Seems like Yamaha is using uppercase `YAMAHA CORPORATION` for the manufacturer info of non-MusicCast devices and normal case `Yamaha Corporation` for MusicCast devices.

* [yamaha] Fix REGEXes for Yamaha binding suggestion and improve description

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
  • Loading branch information
florian-h05 authored and andrasU committed Jan 27, 2024
1 parent f912174 commit af0237e
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,24 @@
xsi:schemaLocation="https://openhab.org/schemas/addon/v1.0.0 https://openhab.org/schemas/addon-1.0.0.xsd">

<type>binding</type>
<name>Yamaha Musiccast Binding</name>
<description>This is the binding for Yamaha Musiccast</description>
<name>Yamaha MusicCast Binding</name>
<description>This is the binding for Yamaha MusicCast.</description>
<connection>local</connection>

<discovery-methods>
<discovery-method>
<service-type>upnp</service-type>
<match-properties>
<match-property>
<name>manufacturer</name>
<regex>.*Yamaha.*</regex>
</match-property>
<match-property>
<name>deviceType</name>
<regex>.*MediaRenderer.*</regex>
</match-property>
</match-properties>
</discovery-method>
</discovery-methods>

</addon:addon>
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# add-on

addon.yamahamusiccast.name = Yamaha Musiccast Binding
addon.yamahamusiccast.description = This is the binding for Yamaha Musiccast
addon.yamahamusiccast.name = Yamaha MusicCast Binding
addon.yamahamusiccast.description = This is the binding for Yamaha MusicCast.

# thing types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<type>binding</type>
<name>YamahaReceiver Binding</name>
<description>For all network enabled Yamaha receivers.</description>
<description>This is the binding for network enabled Yamaha receivers (without MusicCast support).</description>
<connection>local</connection>

<discovery-methods>
Expand All @@ -14,7 +14,7 @@
<match-properties>
<match-property>
<name>manufacturer</name>
<regex>(?i).*YAMAHA.*</regex>
<regex>.*YAMAHA.*</regex>
</match-property>
<match-property>
<name>deviceType</name>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# add-on

addon.yamahareceiver.name = YamahaReceiver Binding
addon.yamahareceiver.description = For all network enabled Yamaha receivers.
addon.yamahareceiver.description = This is the binding for network enabled Yamaha receivers (without MusicCast support).

# thing types

Expand Down Expand Up @@ -160,8 +160,8 @@ channel-type.yamahareceiver.surroundProgram.state.option.Sci-Fi = Sci-Fi
channel-type.yamahareceiver.surroundProgram.state.option.Spectacle = Spectacle
channel-type.yamahareceiver.surroundProgram.state.option.Standard = Standard
channel-type.yamahareceiver.surroundProgram.state.option.Pro\ Logic = Pro Logic
channel-type.yamahareceiver.surroundProgram.state.option.Neo:6 Music = Neo:6 Music
channel-type.yamahareceiver.surroundProgram.state.option.Neo:6 Cinema = Neo:6 Cinema
channel-type.yamahareceiver.surroundProgram.state.option.Neo\:6\ Music = Neo:6 Music
channel-type.yamahareceiver.surroundProgram.state.option.Neo\:6\ Cinema = Neo:6 Cinema
channel-type.yamahareceiver.surroundProgram.state.option.PLII[x]\ Game = PLII[x] Game
channel-type.yamahareceiver.surroundProgram.state.option.PLII[x]\ Music = PLII[x] Music
channel-type.yamahareceiver.surroundProgram.state.option.PLII[x]\ Movie = PLII[x] Movie
Expand Down

0 comments on commit af0237e

Please sign in to comment.