[yamahamusiccast] Add discovery information #16231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like Yamaha is using uppercase `YAMAHA CORPORATION` for the manufacturer info of non-MusicCast devices and normal case `Yamaha Corporation` for MusicCast devices.
lolodomo
reviewed
Jan 13, 2024
| <match-properties> | ||
| <match-property> | ||
| <name>manufacturer</name> | ||
| <regex>(?i).*Yamaha.*</regex> |
There was a problem hiding this comment.
As I understand, (?i) turns on case-insensitive mode. So if you keep it, you will catch value containing either Yamaha or YAMAHA.
Exactly the same result as in the "Yamaha Receiver" binding.
There was a problem hiding this comment.
True, I will fix that.
There was a problem hiding this comment.
I have just commited that @lolodomo .
…ption Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added
rebuild
lolodomo
requested changes
Jan 15, 2024
| # channel types | ||
|
|
||
| channel-type.yamahareceiver.surroundProgram.state.option.Neo:6 Music = Neo:6 Music | ||
| channel-type.yamahareceiver.surroundProgram.state.option.Neo:6 Cinema = Neo:6 Cinema |
There was a problem hiding this comment.
Fixed.
Sorry, I did not check what the i18n plugin generated - I should probably don't trust it without checking what it does.
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
lolodomo
added
the
enhancement
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 27, 2024
* [yamahamusiccast] Add discovery information Seems like Yamaha is using uppercase `YAMAHA CORPORATION` for the manufacturer info of non-MusicCast devices and normal case `Yamaha Corporation` for MusicCast devices. * [yamaha] Fix REGEXes for Yamaha binding suggestion and improve description --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [yamahamusiccast] Add discovery information Seems like Yamaha is using uppercase `YAMAHA CORPORATION` for the manufacturer info of non-MusicCast devices and normal case `Yamaha Corporation` for MusicCast devices. * [yamaha] Fix REGEXes for Yamaha binding suggestion and improve description --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like Yamaha is using uppercase
YAMAHA CORPORATIONfor the manufacturer info of non-MusicCast devices and normal caseYamaha Corporationfor MusicCast devices.Signed-off-by: Florian Hotze florianh_dev@icloud.com