Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly configure Coroutines cmake module #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

karzhenkov
Copy link

@karzhenkov karzhenkov commented Jan 23, 2021

There are some problems when using cppcoro from an external project:

  • the installed library cannot be used if the final version of C++20 coroutines is not supported by toolset;
  • the library cannot be used directly from its build tree, which would sometimes be convenient.

The first commit adds tests that attempt to build an executable using cppcoro:

  • app_build_with_cppcoro_install_dir
  • app_build_with_cppcoro_build_tree
  • helper tests to install cppcoro and configure the application build tree.

Following commits make the tests successful.

This PR should probably go to add_cmake_support, but that branch looks somewhat outdated.

@karzhenkov karzhenkov marked this pull request as ready for review January 23, 2021 11:53
@andreasbuhr
Copy link
Owner

Hi @karzhenkov ,
thanks a lot for your feedback, I'll have a look tomorrow.
I do not maintain the add_cmake_support branch any more, see my latest comment in lewissbaker#174 .

arthurzam added a commit to arthurzam/cppcoro that referenced this pull request Oct 25, 2021
@bhundt
Copy link

bhundt commented Aug 13, 2022

Any update of integrating this into the main branch? I stumbled upon the same problem and it would be nice to be able to just clone the main branch from my build system. Thank you guys for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants