Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't make config-galaxy-s2 because of error in copy_file #244

Closed
davidflanagan opened this issue Mar 27, 2012 · 1 comment
Closed

can't make config-galaxy-s2 because of error in copy_file #244

davidflanagan opened this issue Mar 27, 2012 · 1 comment

Comments

@davidflanagan
Copy link
Collaborator

See https://github.com/cgjones/android_device_samsung_galaxys2/blob/gingerbread/extract-files.sh#L145

The copy_file function is only used twice in this file, and both times it renames the file it copies. But it is written to check for the existance of the file by its original name, so it always fails.

Change the $1 to a $2 to fix, I think
@davidflanagan
Copy link
Collaborator Author

Also: ./extract-files.sh: line 403: [: missing `]'

kanru added a commit to kanru/B2G that referenced this issue Mar 27, 2012
@kanru
Update firmware extractor. Fixes andreasgal#185, Fixes andreasgal#231, …
0129c84 
…Fixes andreasgal#238, Fixes andreasgal#244.
jonallengriffin pushed a commit to jonallengriffin/B2G that referenced this issue Mar 27, 2012
@andreasgal
Merge pull request andreasgal#246 from kanru/firmware-extractor
27a39ea 
Update firmware extractor. Fixes andreasgal#185, Fixes andreasgal#231, Fixes andreasgal#238, Fixes andreasgal#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreasgal @davidflanagan