fix for routes with bool fields #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create BooleanFilter.js * filtered output * clarify inputFalse comment * initial but tested version * Create BooleanTrigger.js see https://x3dom-booleantrigger.glitch.me/ * Create IntegerTrigger.js see https://x3dom-integertrigger.glitch.me/ * Create TimeTrigger.js see https://x3dom-timetrigger.glitch.me/ * add EventUtilties component and files * formatting * tabs * tabs * tabs * Create X3DTriggerNode.js * extend X3DTriggerNode * extend X3DTriggerNode * extend X3DTriggerNode * Create X3DSequencerNode.js see IntegerSequencer branch for history * Create BooleanSequencer.js see IntegerSequencer branch * Create IntegerSequencer.js see IntegerSequencer branch * fixesuggested by LGTM (x3dom#747) * declare local variables in three files * cleaning
a boolean field with a default value of 'false' was not recognized as existing; use explicit check for undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.