Pass the node to the supstance drag event listener #98
Conversation
Conflicts: dist/techan.js dist/techan.min.js dist/techan.min.js.map Merge from forked source.
to the tick date, even if that date is smaller than the tick date. Currently it only uses the closest date that is greater than the tick date.
| @@ -308,7 +308,16 @@ module.exports = function(d3_scale_linear, d3_time, d3_bisect, techan_util_rebin | |||
| return function(d) { | |||
| var value = visibleDomainLookup[+d]; | |||
| if (value !== undefined) return visibleDomain[value]; | |||
| return visibleDomain[d3_bisect(visibleDomain, d)]; | |||
| var index = d3_bisect(visibleDomain, d); | |||
|
Hi @sf-wind Thanks again for the contribution. This appears to have pull request #100 merged in already making a bit harder to review. I also won't be able to merge it in until #100 is merged in. Any chance those commits could be taken out? Otherwise this one will have to wait until then. cheers |
| @@ -57,7 +57,7 @@ module.exports = function(d3_behavior_drag, d3_event, d3_select, d3_dispatch, ac | |||
| accessor.v(d, value); | |||
| annotationSelection.each(plot.annotation.update(annotation, d3_event().y)); | |||
| refresh(g, plot, accessor, x, y, annotationSelection, annotation); | |||
| dispatch.drag(d); | |||
| dispatch.drag(d, g); | |||
There was a problem hiding this comment.
This is handy, but it should align to d3 the api, generally passing (d, i) as parameters and this being the node as documented here https://github.com/mbostock/d3/wiki/Selections#on
The specified listener is invoked in the same manner as other operator functions, being passed the current datum d and index i, with the this context as the current DOM element.
|
Thanks. This is my first pull request and I did it on my master branch by mistake. As for the d3 api, I'm not quite familiar with and I will definite take a look. |
In my use case, when dragging a line, some other related lines also move. I use it to implement fibonacci trend, so the registered drag event listener needs to know which line is dragged. So add the node as a second argument.