Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calculator.php #2

Closed
wants to merge 2 commits into from
Closed

Conversation

madika
Copy link

@madika madika commented May 8, 2017

For edge cases (calculating work days for e.g. into the next year) holidays should be matched based on year

@coveralls
Copy link

coveralls commented May 8, 2017

Coverage Status

Coverage decreased (-4.2%) to 95.833% when pulling 6e3085d on madika:master into 9c03818 on andrejsstepanovs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 997fc5b on madika:master into 9c03818 on andrejsstepanovs:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 997fc5b on madika:master into 9c03818 on andrejsstepanovs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 997fc5b on madika:master into 9c03818 on andrejsstepanovs:master.

@andrejsstepanovs
Copy link
Owner

andrejsstepanovs commented May 8, 2017

Hi @madika !

Thanks for PR. But you should use "free days" for specific year holidays.

->setFreeDays($freeDays);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants