Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GitHub URL should preserve query args #453

Merged
merged 4 commits into from
Feb 6, 2022
Merged

fix: GitHub URL should preserve query args #453

merged 4 commits into from
Feb 6, 2022

Conversation

andreoliwa
Copy link
Owner

Proposed changes

  1. The GitHubURL class should preserve query args.

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1801387348

  • 61 of 61 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.038%
Totals Coverage Status
Change from base Build 1800940635: 0.01%
Covered Lines: 2064
Relevant Lines: 2110
💛 - Coveralls

@andreoliwa andreoliwa merged commit a2b97b1 into develop Feb 6, 2022
@andreoliwa andreoliwa deleted the preserve-query-string branch February 6, 2022 05:00
github-actions bot pushed a commit that referenced this pull request Mar 27, 2022
@semantic-release-bot
chore(release): 0.32.0 [skip ci]
66fa857 
# [0.32.0](v0.31.0...v0.32.0) (2022-03-27)

### Bug Fixes

* **deps:** update dependency pytest-socket to a commit hash ([#440](#440)) ([61ac278](61ac278))
* GitHub URL should preserve query args ([#453](#453)) ([a2b97b1](a2b97b1))
* use built-in preset as default style ([#450](#450)) ([68fa2ce](68fa2ce))

### Features

* add --version cli switch (thanks to [@mjpieters](https://github.com/mjpieters)) ([#468](#468)) ([6a85f79](6a85f79))
* resolve relative URIs in nitpick.styles.include ([#470](#470)) ([ec934dc](ec934dc))
* set initial style url(s) with nitpick init ([#473](#473)) ([0100f2b](0100f2b))
* switch to requests-cache for style caching ([#467](#467)) ([c586d7f](c586d7f))
@github-actions
Copy link

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Feature/fix is released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreoliwa @coveralls