Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style override on Windows #422

Merged
merged 13 commits into from Jan 13, 2022
Merged

fix: style override on Windows #422

merged 13 commits into from Jan 13, 2022

Conversation

andreoliwa
Copy link
Owner

Fixes #418

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@andreoliwa andreoliwa mentioned this pull request Dec 24, 2021
Closed
@coveralls
Copy link

coveralls commented Dec 24, 2021 •
edited

Pull Request Test Coverage Report for Build 1691767970

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 97.033%
Totals Coverage Status
Change from base Build 1690870011: -0.001%
Covered Lines: 2001
Relevant Lines: 2045
💛 - Coveralls

@andreoliwa andreoliwa added this to In progress in Nitpick Roadmap Dec 25, 2021
@andreoliwa andreoliwa merged commit e7d2897 into develop Jan 13, 2022
Nitpick Roadmap automation moved this from In progress to Done Jan 13, 2022
@andreoliwa andreoliwa deleted the style-override-on-windows branch January 13, 2022 09:07
github-actions bot pushed a commit that referenced this pull request Jan 14, 2022
@semantic-release-bot
chore(release): 0.30.0 [skip ci]
8a1d2bd 
# [0.30.0](v0.29.0...v0.30.0) (2022-01-14)

### Bug Fixes

* style override on Windows ([#422](#422)) ([e7d2897](e7d2897))
* use current dir; don't climb dirs to find the project root ([#421](#421)) ([3c82e8c](3c82e8c))

### Features

* default pre-commit hook now runs "nitpick fix" ([cb4c242](cb4c242))
* **json:** autofix JSON files ([#429](#429)) ([4b58a03](4b58a03))
* nitpick init adds a [tool.nitpick] section ([36f4065](36f4065))
* **yaml:** autofix .pre-commit-config.yaml (note: style changed!) ([#434](#434)) ([352b53d](352b53d))
* **yaml:** autofix GitHub Workflow files ([#437](#437)) ([6af77c4](6af77c4))
* **yaml:** autofix YAML files ([#431](#431)) ([d8cc4b1](d8cc4b1))
@github-actions
Copy link

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Feature/fix is released
Projects
Nitpick Roadmap
Archived in project
Nitpick Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple styles are not cross-platform compatible
2 participants
@andreoliwa @coveralls