Skip to content

Commit

Permalink
Fixing one more issue
Browse files Browse the repository at this point in the history
  • Loading branch information
Andre Rodrigues committed Oct 12, 2012
1 parent 998585a commit 3664ccd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/services/core/servicesettings.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,5 +202,5 @@ exports.matchedSpecification = function (settings) {
}
}

return (settings.length === 0);
return util.objectKeysLength(settings) === 0;
};
6 changes: 3 additions & 3 deletions lib/services/core/storageservicesettings.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ StorageServiceSettings._getDevelopmentStorageAccount = function (proxyUri) {
var parsedUri = url.parse(proxyUri);
var scheme = parsedUri.protocol;
var host = parsedUri.host;
var prefix = scheme + '://' + host;
var prefix = scheme + '//' + host;

return new StorageServiceSettings(
ConnectionStringKeys.DEV_STORE_NAME,
Expand Down Expand Up @@ -216,12 +216,12 @@ StorageServiceSettings.createFromConnectionString = function (connectionString)
);

if (matchedSpecs) {
proxyUri = util.tryGetValueInsensitive(
var proxyUri = util.tryGetValueInsensitive(
ConnectionStringKeys.DEVELOPMENT_STORAGE_PROXY_URI_NAME,
tokenizedSettings
);

return _getDevelopmentStorageAccount(proxyUri);
return this._getDevelopmentStorageAccount(proxyUri);
}

// Automatic case
Expand Down
4 changes: 2 additions & 2 deletions test/services/core/storageservicesettings-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ suite('storageservicesettings-tests', function () {

// Test
var actual = StorageServiceSettings.createFromConnectionString(connectionString);

// Assert
actual._name.should.equal(expectedName);
actual._key.should.equal(expectedKey);
actual._blobEndpointUri.should.equal(expectedBlobEndpoint);
actual._queueEndpointUri.should.equal(expectedQueueEndpoint);
actual.tableEndpointUri.should.equal(expectedTableEndpoint);
actual._tableEndpointUri.should.equal(expectedTableEndpoint);
});
/*
test('testCreateFromConnectionStringWithUseDevStoreUri', function () {
Expand Down

0 comments on commit 3664ccd

Please sign in to comment.