Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom preview component #56

Closed
go1dfish opened this issue Nov 17, 2017 · 5 comments
Closed

Support for custom preview component #56

go1dfish opened this issue Nov 17, 2017 · 5 comments
Assignees

Comments

@go1dfish
Copy link

Would be nice to be able to specify a custom component for previews in order to support customized markdown parsers.

@andrerpena
Copy link
Owner

This is a good idea.. I'll keep this open

@andrerpena
Copy link
Owner

I'll make this as part of an effort of decoupling the components and making react-mde more flexible:
Relevant thread: #51

@andrerpena
Copy link
Owner

andrerpena commented Nov 21, 2017

I'm now implementing the ability for your to select each command you'd like (#58) , and right after that, I'll improve the composability of react-mde.

This is the next task in the queue.

@go1dfish
Copy link
Author

Sweet. We're looking at using this for https://github.com/decred/politeiagui and currently we use the Snudownd markdown parser and are likely to customize from there.

@andrerpena
Copy link
Owner

Thank you very much for considering using react-mde in your project.

After further consideration, I think the only way to make react-mde to support multiple previews is by breaking it down into 3 separate components and NPM packages (the toolbar, the textarea and a full-blown including the preview). This is because, even though I can strip react-mde in separate components in a single NPM package, the peerDependence to showdown will still be there. And having multiple NPM packages will complicate my life now.

I think I'll have to stick with showdown for now =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants