link gh issues to v1 part 2

.eslintignore

@@ -2,3 +2,5 @@
 /node_modules
 **/node_modules
 /scripts
+tests
+testing

package.json

@@ -28,6 +28,7 @@
     "eslint-plugin-prettier": "^3.0.1",
     "jest": "^24.1.0",
     "jest-cli": "^24.1.0",
+    "jest-when": "^2.3.1",
     "lerna": "^3.13.1",
     "node-fetch": "^2.3.0",
     "prettier": "^1.16.4",

packages/azure-functions/tests/webhooked.test.js

@@ -10,12 +10,9 @@ beforeEach(() => {
     handle,
   });
 });
-
 test('configures webhooked and handles request', async () => {
   const request = {
-    headers: {
-      'x-github-event': 'issues',
-    },
+    headers: {},
     body: { some: 'json' },
   };
 
@@ -25,3 +22,13 @@ test('configures webhooked and handles request', async () => {
   expect(handle).toBeCalledWith(request);
   expect(context.res.status).toEqual(200);
 });
+
+test('responds with a 500 status on error', async () => {
+  const request = {};
+  webhooked.mockImplementation(() => {
+    throw new Error('failure');
+  });
+  await httpFunction(context, request);
+
+  expect(context.res.status).toEqual(500);
+});

packages/webhooked-github-request-matchers/src/index.js

@@ -1,9 +1,7 @@
-const isRequestFromGithub = req => {
-  return Boolean(req.headers['x-github-event']);
-};
+const isRequestFromGithub = require('./isRequestFromGithub');
 
-const matchesActions = (req, actions = []) => {
-  if (!isRequestFromGithub(req)) {
+const matchesActions = (req, actions = [], key = '') => {
+  if (!isRequestFromGithub(req, key)) {
     return false;
   }
   return Boolean(actions.find(action => req.body.action === action));

packages/webhooked-github-request-matchers/src/isRequestFromGithub.js

@@ -0,0 +1,7 @@
+const { createHmac } = require('crypto');
+
+module.exports = (req, hmacKey) =>
+  req.headers['x-hub-signature'] ===
+  `sha1=${createHmac('sha1', hmacKey)
+    .update(JSON.stringify(req.body))
+    .digest('hex')}`;

packages/webhooked-github-request-matchers/tests/isRequestFromGIthub.test.js

@@ -1,15 +1,24 @@
+const { createHmac } = require('crypto');
 const { isRequestFromGithub } = require('../src');
 
 test('can determine whether a request is from a github API event', () => {
+  const key = 'hmacKey';
+  const body = {
+    some: 'payload',
+  };
   const ghRequest = {
     headers: {
-      'x-github-event': 'issues',
+      'x-hub-signature': `sha1=${createHmac('sha1', key)
+        .update(JSON.stringify(body))
+        .digest('hex')}`,
     },
+    body,
   };
-  expect(isRequestFromGithub(ghRequest)).toBeTruthy();
+  expect(isRequestFromGithub(ghRequest, key)).toBeTruthy();
 
   const nonGHRequest = {
     headers: {},
+    body,
   };
-  expect(isRequestFromGithub(nonGHRequest)).toBeFalsy();
+  expect(isRequestFromGithub(nonGHRequest, key)).toBeFalsy();
 });

packages/webhooked-github-request-matchers/tests/matchesActions.test.js

@@ -1,22 +1,39 @@
+jest.mock('../src/isRequestFromGithub');
+const { when } = require('jest-when');
 const { matchesActions } = require('../src');
+const isRequestFromGithub = require('../src/isRequestFromGithub');
+const key = 'key';
 
 test('returns false if the request is not a github api event', () => {
   const nonGHRequest = {
     headers: {},
   };
+  when(isRequestFromGithub)
+    .calledWith(nonGHRequest, key)
+    .mockReturnValue(false);
+
   expect(matchesActions(nonGHRequest)).toBeFalsy();
 });
 
-test('returns false if not actions are provided', () => {
-  expect(matchesActions(createGHRequest())).toBeFalsy();
+test('returns false if no actions are provided', () => {
+  when(isRequestFromGithub)
+    .calledWith(createGHRequest(), key)
+    .mockReturnValue(true);
+  expect(matchesActions(createGHRequest(), key)).toBeFalsy();
 });
 test('returns false if the action is not matched', () => {
-  expect(matchesActions(createGHRequest(), ['created'])).toBeFalsy();
+  when(isRequestFromGithub)
+    .calledWith(createGHRequest(), key)
+    .mockReturnValue(true);
+  expect(matchesActions(createGHRequest(), ['created'], key)).toBeFalsy();
 });
 
 test('returns true if the request matches any one of the provided actions', () => {
+  when(isRequestFromGithub)
+    .calledWith(createGHRequest(), key)
+    .mockReturnValue(true);
   expect(
-    matchesActions(createGHRequest(), ['created', 'labeled']),
+    matchesActions(createGHRequest(), ['created', 'labeled'], key),
   ).toBeTruthy();
 });