~LogMessage should be declared noexcept(false)

[eigenbom]

C++11 implicitly makes destructors noexcept, causing the system to terminate() instead of throwing.

~LogMessage noexcept(false)

[andrew-d]

Thanks for the report!

[eigenbom]

hey no worries, thx for the library!

was also wondering if ~LogMessage() needs to be virtual? (or is it for extendability?)

[andrew-d]

Yeah, it's for extendability - cpplog supports defining a custom LOG_LEVEL macro (see here where we only define ours if it's not previously defined). If someone created one that used a subclass of LogMessage (maybe along with a custom logger that does extra stuff with the message), we need the destructor on the base class to be virtual.

[eigenbom]

AH yeah cool, no problem :)