Merge pull request #59 from andrew-hossack/dev

Dev
andrew-hossack · Aug 30, 2022 · 9eb6ee4 · 9eb6ee4
2 parents 31c5157 + 5da1a8b
commit 9eb6ee4
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/dashtools/deploy/herokuUtils.py b/dashtools/deploy/herokuUtils.py
@@ -53,15 +53,14 @@ def check_heroku_app_name_available(heroku_app_name: str) -> bool:
         True if available
         False if not
     """
-    try:
-        requests.get(
+    response = requests.get(
             url=f'https://{heroku_app_name}.herokuapp.com/',
             headers={'User-Agent': 'Custom'}
         )
-        return False
-    except requests.exceptions.ConnectionError as e:
+    if response.status_code == 404:
         return True
-
+    else:
+        return False
 
 def create_app_on_heroku(app_name: str) -> bool:
     """

diff --git a/dashtools/version.py b/dashtools/version.py
@@ -1 +1 @@
-__version__ = '1.8.2'
+__version__ = '1.8.3'
diff --git a/docs/source/changelog.md b/docs/source/changelog.md
@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.8.3] - 2022-08-29
+
+### Fixed
+
+- Changed heroku app name verification again. Heroku sends back a 404 if no app name is in use. Thanks @lanchuhuong!
+
 ## [1.8.2] - 2022-08-12
 
 ### Fixed

diff --git a/docs/source/version.py b/docs/source/version.py
@@ -1,3 +1,3 @@
 # Version in this file must match version for dashtools/version.py!
 
-__version__ = '1.8.2'
+__version__ = '1.8.3'
diff --git a/requirements.txt b/requirements.txt
@@ -3,10 +3,9 @@ dash-bootstrap-components
 Flask
 gunicorn
 packaging==21.0
-setuptools==47.1.0
 pipreqs==0.4.11
 pre-commit==2.16.0
 pytest==6.2.2
 pandas
 yolk3k==0.9
-termcolor==1.1.0
+termcolor==1.1.0