Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics on dashboard #241

Merged
merged 2 commits into from
May 9, 2014
Merged

Metrics on dashboard #241

merged 2 commits into from
May 9, 2014

Conversation

swrobel
Copy link
Contributor

@swrobel swrobel commented Apr 8, 2014

No description provided.

@andrew
Copy link
Member

andrew commented Apr 8, 2014

Thanks @swrobel, do you have a screenshot of how this looks?

@swrobel
Copy link
Contributor Author

swrobel commented Apr 8, 2014

screen shot 2014-04-08 at 7 53 14 am

@andrew
Copy link
Member

andrew commented Apr 14, 2014

Can you perhaps wrap the metrics bit in brackets or make it not bold so as to make it a little more clear that its not part of the title of the experiment?

@mrappleton any thoughts of the visual of this?

@swrobel
Copy link
Contributor Author

swrobel commented Apr 14, 2014

I was following the style of the Goal presentation but I have to admit that isn't great.

@swrobel
Copy link
Contributor Author

swrobel commented May 9, 2014

Just following up on this. I admit the UX isn't great, but I'm no designer and it's the same as the way Goals are currently shown on the dashboard.

andrew pushed a commit that referenced this pull request May 9, 2014
@andrew andrew merged commit 9e96b47 into splitrb:master May 9, 2014
@andrew
Copy link
Member

andrew commented May 9, 2014

@swrobel I've merged this in now, will hopefully get chance to push a new release next week, cheers!

@swrobel
Copy link
Contributor Author

swrobel commented May 9, 2014

Awesome!
On May 9, 2014 2:38 AM, "Andrew Nesbitt" notifications@github.com wrote:

@swrobel https://github.com/swrobel I've merged this in now, will
hopefully get chance to push a new release next week, cheers!


Reply to this email directly or view it on GitHubhttps://github.com//pull/241#issuecomment-42649074
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants