Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethodError: Subscription.prorate #68

Closed
yas4891 opened this issue Sep 23, 2014 · 1 comment · Fixed by #74
Closed

NoMethodError: Subscription.prorate #68

yas4891 opened this issue Sep 23, 2014 · 1 comment · Fixed by #74

Comments

@yas4891
Copy link
Collaborator

yas4891 commented Sep 23, 2014

There's no method subscription#prorate - yet it gets called in SubscriptionController#update (line 143). The line was introduced by a PullRequest merged on Aug 19 from @hanchang

@hanchang
Copy link
Contributor

Sorry about that - the fix (PR #74) is to remove the subscription#prorate method call which I incorrectly assumed would pass parameters to the actual Stripe::Subscription object.

Instead, I've added the proper logic in the processing! method of the Koudoku::Subscription concern so that it passes the config setting for prorating in koudoku.rb.

Hope this does the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants