Use constant for supported extensions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModelLoader was updated to support multiple extensions but the corresponding watch code in YamdlConfig.autoreload_ready also needs to watch for the same extensions.
andrewgodwin
approved these changes
Jan 2, 2023
|
I like it as a class property so I'll take this as-is - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelLoader was updated to support multiple extensions but the corresponding watch code in YamdlConfig.autoreload_ready also needs to watch for the same extensions.
I'm not sure if a class property is better than a module property or not. Do you have any thoughts or preferences?