Add wait between retries when there are download errors #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently gvm makes three attempts at retrying a failed download, but it doesn't wait in between. This commit adds rudimentary wait time between downloads. In a future refactoring we could use `go-retryablehttp`[^1] (we'd still need to guard for errors with `io.Copy`) but keeping the improvement short for now, hoping to reduce download related CI failures.
andrewkroh
approved these changes
Sep 1, 2023
Thanks for the quick review! Added in d9cfa89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
gvmmakes three attempts at retrying a failed download, but it doesn't wait in between.This commit adds rudimentary wait time between download attempts. It also increases the number
of retries to 5.
In a future refactoring we could use
go-retryablehttp1 (we'd still need to guard for errors withio.Copy) but keeping theimprovement short for now, hoping to reduce download related CI failures.
Footnotes
https://pkg.go.dev/github.com/hashicorp/go-retryablehttp#section-readme ↩