Set default model to first model available, not llama2. Refactor API connectivity check.
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnguonly
changed the title
not llama2. Refactor API connectivity check.llama2. Refactor API connectivity check.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #126.
If a user never opens the Options page, then the default model is hardcoded to
llama2. Ifllama2isn't available, then no error is displayed and the app hangs when calling/api/generate(which returns a 404).Solution: Set the default model to the first model returned from
/api/tagsand persist the model even if the user never visits the Options page. The API connectivity check logic is also refactored into a common function.