-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added relative
method to Polish locale
#480
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More clearly regexp in escapeRegExp.
…ld be in the past
function returns a non-undefined value.
global object (Issue andrewplummer#422).
hyphen when in number mode. (Issue andrewplummer#418)
initial merge check.
Corresponding change to issue andrewplummer#434
Documentation of Array.to ambiguous
Also deleted `past`, `future` and `duration` format strings, as they are now handled by the `relative` method. Also added missing 3rd form for days `dni` and fixed singular for month `miesiąc`.
pepkin88
changed the title
Added
Added Jan 14, 2015
relative
methodrelative
method to Polish locale
Hi... I've finally patched in your pull request here: eea0cca Sorry for taking so long! FYI I also got started writing the unit tests as well: All you have to do is uncomment, fill in, and fix wording as necessary... If you're ever so inclined! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deleted
past
,future
andduration
format strings, as they are now handled by therelative
method.Also added missing 3rd form for days
dni
and fixed singular form for monthmiesiąc
.I hope that it doesn't break backward compatibility. I was relying on the
relative
method from Russian locale.I used the following test cases and for each case it sounds correct: