Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile errors #24

Closed
thomaxxl opened this issue May 19, 2015 · 4 comments · Fixed by #55
Closed

compile errors #24

thomaxxl opened this issue May 19, 2015 · 4 comments · Fixed by #55

Comments

@thomaxxl
Copy link

Hi,

I had to change some makefiles to get pokerstove compiled:
added -std=c++11 to CMAKE_CXX_FLAGS in ./src/lib/pokerstove/penum/CMakeLists.txt

and -lpthread to ./CMakeFiles/util_tests.dir/link.txt

@andrewprock
Copy link
Owner

Please add a push request and I will check it out.

Sent from Type Mail

On May 19, 2015, 1:44 AM, at 1:44 AM, Thomas Pollet notifications@github.com wrote:

Hi,

I had to change some makefiles to get pokerstove compiled:
added -std=c++11 to CMAKE_CXX_FLAGS in
./src/lib/pokerstove/penum/CMakeLists.txt

and -lpthread to ./CMakeFiles/util_tests.dir/link.txt


Reply to this email directly or view it on GitHub:
#24

@sjlnk
Copy link

sjlnk commented May 19, 2015

In addition to what @thomaxxl mentioned I needed to put that -std=c++11 also in CMakeLists.txt files in peval and util as well.

So to sum it up, the following changes are neccessary to get the newest commit (0f057ff) to compile:

Add -std=c++11 in CMAKE_CXX_FLAGS in following files:

  • ./src/lib/pokerstove/penum/CMakeLists.txt
  • ./src/lib/pokerstove/penum/CMakeLists.txt
  • ./src/lib/pokerstove/util/CMakeLists.txt

After that run cmake and make. It will stop on error when trying to build the testkit (undefined reference to some pthread stuff). So at that point you need to modify the compiled file in {build_dir}/lib/pokerstove/util/CMakeFiles/util_tests.dir/link.txt and add -lpthread in the end. Now run make again and it should compile.

I could add a push request but I'm not sure how to address the problem with googletest properly.

@Pretenderr
Copy link

Add -std=c++11 in CMAKE_CXX_FLAGS in following files:
./src/lib/pokerstove/peval/CMakeLists.txt

@scraggelz
Copy link

These were very helpful seeing as the -std=c++11 and lpthread were giving me trouble when compiling. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants