Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use npm install #291

Closed
wants to merge 1 commit into from
Closed

use npm install #291

wants to merge 1 commit into from

Conversation

ralphtheninja
Copy link

I changed npm run build to npm install and instead using the postinstall for the build step, which is automatically run by npm after the dependencies are installed.

@andrewrk
Copy link
Owner

I do like this better for development, but this breaks npm install groovebasin because that does not install devDependencies and then when postinstall runs you get:

./build: line 3: ./node_modules/.bin/stylus: No such file or directory
./build: line 4: ./node_modules/.bin/browserify: No such file or directory
npm ERR! groovebasin@1.1.0 postinstall: `./build`
npm ERR! Exit status 127
npm ERR! 
npm ERR! Failed at the groovebasin@1.1.0 postinstall script.
...

@andrewrk andrewrk closed this Jun 29, 2014
@ralphtheninja
Copy link
Author

Then browserify and stylus clearly are dependencies and not devDependencies.

@andrewrk
Copy link
Owner

No - you don't need stylus and browserify to run groovebasin, only to build it.

@ralphtheninja
Copy link
Author

Gotcha. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants