Fixed memory leak #222
Merged
Fixed memory leak #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I need to put this free's somewhere else. I guess there can be cases this fix doesn't account for, but where I put them now fixed the problem I'm having. |
wegylexy
suggested changes
May 14, 2020
Co-authored-by: TimTim <i@timtim.hk>
Co-authored-by: TimTim <i@timtim.hk>
|
thank you, @wegylexy! :-) |
|
@andrewrk Could we soon merge this fix? |
|
@andrewrk Do you also have time to evaluate the other pull requests? Especially those WASAPI ones as the current thing is partially broken on Windows 10 v2004. |
|
No I won't be making another release for about 2 years, but then it should pick back up. The biggest problem with pull requests is testing. QA for this software is near impossible, we need actual hardware and half the time I ask people if they tested their code, they say "no, I just guessed this would work". |
jomael
added a commit
to jomael/libsoundio
that referenced
this pull request
Aug 7, 2021
Fixed memory leak (andrewrk#222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this amazing lib. The API looks amazing!
So I just started testing soundio, but I kept getting a visual leak detection. The leak was caused by
soundio_connect(soundio);