maxresdefault vs hqdefault #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix img tag in picture doesn't use the $id
maxresdefault doesn't work in some videos. hqdefault can solve this problem
Bugfix :
|
Thank you a lot! |
|
You're welcome!
I've seen you have updated this component to 1.0.4 with this changes applied but './dist/' is still the same. I've never publish a npm package (I don't know how it works) but you don't need to build to apply the changes to './dist'?
|
|
Sorry for the mistake. I will fix it in a hour. And again thanks a lot for contributing. |
|
Published updated |
|
Hi! I've been offline since 14th May and I couldn't test this issue. Thank you for your patience. Yes, the problem has been fixed.
|
andrewvasilchuk
requested review from
andrewvasilchuk
and removed request for
andrewvasilchuk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only 1080 videos have the
maxresdefaultthumbnail and will not work on most of the YouTube videos.I've taken a look at YouTube HTML and even they use the
hqdefaultthumbnail.Also, if the web explorer can't use the
.webpand tries the.jpgit shows an image from the other YouTube video (4JS70KB9GS0).