Byte Order Mark skipping #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try reading two files with Byte Order Marks. test_sax_fsm_1_utf8_bom.in is UTF8 encoded (but this is not mentioned in the XML header). We should be able to read this as long as we don't trip up with the BOM. test_sax_fsm_1_utf16_bom.in is UTF16 encoded with a BOM and encoding declared in the XML. We should not be able to read this (we should get a non-well-formed error).
For a UTF8-encoded XML file with a Byte Order Mark and characters that are also ascii characters, we should be able to read the file. If the first character is not- recognisable assume we are dealing with a BOM, skip it, and carry on. We'll then either read the file OK or we end up with something that is not well-formed (e.g. because it is a different encoding).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip any Byte Order Marks and keep trying. We may be able to read some files.