Can't set noload and (branch|tag|commit) options simultaneously

[evanrelf]

This works without any errors:

plug 'andreyorst/plug.kak' noload

However, this gives me an error:

plug 'andreyorst/plug.kak' 'branch: v2018.10.27' noload

~/.config/kak/plugins.kak:3:54: 'plug' 3:57: 'evaluate-commands' 2:66: 'plug-configure' 1:2: 'evaluate-commands' no such command: 'noload'
/Users/evanrelf/.config/kak/kakrc:1:1: 'source' 3:54: 'plug' 3:57: 'evaluate-commands' 2:66: 'plug-configure' 1:2: 'evaluate-commands' no such command: 'noload'
/usr/local/Cellar/kakoune/2018.10.27/share/kak/kakrc:5:853: 'evaluate-commands' 97:20157: 'source' 1:1: 'source' 3:54: 'plug' 3:57: 'evaluate-commands' 2:66: 'plug-configure' 1:2: 'evaluate-commands' no such command: 'noload'
error while parsing kakrc:
    1:1: 'source' 5:853: 'evaluate-commands' 97:20157: 'source' 1:1: 'source' 3:54: 'plug' 3:57: 'evaluate-commands' 2:66: 'plug-configure' 1:2: 'evaluate-commands' no such command: 'noload'

I'm using kak-lsp with a noload parameter and it works fine; it's only when I try to combine noload and a (branch|tag|commit) parameter that it gives that error.

Tested on the latest commit (b3801d2) and one before that (98defec); both had this problem.

[andreyorst]

Unfortunately plug.kak can't change it's own branch since it must be loaded to change it, and after changing it old loaded branch of plug.kak is used still, therefore Kakoune needs a restart. I suggest to switch branch manually for plug.kak and treat it as part of its installation process.

I'll investigate the problem with combining these two attributes.

[evanrelf]

That makes sense

[andreyorst]

Should be working now. Fix is in kakoune-git branch. Can you test it there, and report back? I'll add it to default branch if it works on your configuration

[andreyorst]

Also v2018.10.27 is the default branch. You don't need to specify it explicitly with `"branch:" command

[evanrelf]

Yeah I’ll test it when I get a chance. I know that’s the default branch right now, but what if you change the default in the future before I update Kakoune? 🙂

[evanrelf]

It works!