-
Notifications
You must be signed in to change notification settings - Fork 295
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various problems processing long lines in EULA file #62
Comments
sidney
added a commit
to sidney/create-dmg
that referenced
this issue
Oct 7, 2018
…file Split long lines into chunks by number of characters without introducing unnecessary changes such as newlines or extra spaces. The resource handles chunked pieces fine, not caring if it is split by sentences or wrapped across lines.
aonez
added a commit
that referenced
this issue
Oct 9, 2018
Issue #62 - Various problems processing long lines in EULA file
Thanks a lot @sidney! Merged 😊 This one solves:
|
Closed
aonez
referenced
this issue
Jan 2, 2021
#109 Based on a thread from dawn2dusk & peterguy https://developer.apple.com/forums/thread/668084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the --eula option specifies a file that contains lines longer than 1000 characters, the code that breaks up the long lines so that they are not too long for the Mac OS resource handling is incorrect.
The most obvious error is that a new line is inserted after every "." character.
1.5.2. This is a short sentence. It starts a long paragraph of longer than 1000 characters
becomes
It will also exit with a failure if given a file containing a sequence more than 1000 characters that has no newlines and no "."
I have a pull request I'm preparing that both simplifies the existing code and fixes this.
The text was updated successfully, but these errors were encountered: