Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various problems processing long lines in EULA file #62

Closed
sidney opened this issue Oct 7, 2018 · 1 comment
Closed

Various problems processing long lines in EULA file #62

sidney opened this issue Oct 7, 2018 · 1 comment

Comments

@sidney
Copy link
Collaborator

sidney commented Oct 7, 2018

When the --eula option specifies a file that contains lines longer than 1000 characters, the code that breaks up the long lines so that they are not too long for the Mac OS resource handling is incorrect.

The most obvious error is that a new line is inserted after every "." character.

1.5.2. This is a short sentence. It starts a long paragraph of longer than 1000 characters

becomes

1.
5.
2.
This is a short sentence.
It starts a long paragraph of longer than 1000 characters

It will also exit with a failure if given a file containing a sequence more than 1000 characters that has no newlines and no "."

I have a pull request I'm preparing that both simplifies the existing code and fixes this.

sidney added a commit to sidney/create-dmg that referenced this issue Oct 7, 2018
…file

Split long lines into chunks by number of characters without introducing unnecessary changes such as newlines or extra spaces. The resource handles chunked pieces fine, not caring if it is split by sentences or wrapped across lines.
aonez added a commit that referenced this issue Oct 9, 2018
Issue #62 - Various problems processing long lines in EULA file
@aonez
Copy link
Member

aonez commented Oct 9, 2018

Thanks a lot @sidney! Merged 😊

This one solves:

Adding an RTF EULA fails if the RTF contains long lines of text or long sentences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants