-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable SSH multiplexing if not supported #1093
Conversation
This is my attempt at fixing #1092. It is not completely consistent with how we sync (it's missing the occasional sync commit, which we may want to include in the PullOperation anyway) and untested. @msfjarvis Could you take over from here? |
Sure thing. |
…story Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
That story is 5/5. |
9c3ef5b
to
52b8f42
Compare
* develop: build: update Kotlin and dependency-updates plugin (#1094)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Works for me now, but the double authentication w/ keystore-backed SSH keys sure is annoying. Get your shit together Bitbucket. |
We could get around this by only showing the prompt if the reauth timeout hasn't passed. As it is currently at 30 or 15 seconds, that should mostly work unless the user is on a really slow connection. |
I'd rather just let it be at this point. |
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
If the macOS runner is gonna be slow af anyway might as well get the trivial stuff done too. |
📢 Type of change
📜 Description
Fall back to single channel SSH connections if the server (looking at you, Bitbucket) does not support multiplexing.
💡 Motivation and Context
Should fix #1092 when it's done.
💚 How did you test it?
Not yet.Create a private Bitbucket repository, clone it to the device, attempt to synchronize after creating a new password and get the error about broken multiplexing then trying again correctly uses a pull + push separately.📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs