Configure IME options and focus direction #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
fmeum
approved these changes
May 28, 2020
msfjarvis
added a commit
to fmeum/Android-Password-Store
that referenced
this pull request
May 30, 2020
* master: github: run PSL update workflow weekly (android-password-store#809) Update Public Suffix List data (android-password-store#808) Remove HOTP/TOTP support (android-password-store#806) Configure IME options and focus direction (android-password-store#805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Configure
nextFocusForwardandimeOptionsto correctly navigate IME enter key across the server config UI💡 Motivation and Context
Before this change pressing the IME enter button would take you from username -> server url -> repo path, now it's something like this: username -> server url -> port -> repo path -> ime closes on each press of the enter button.
💚 How did you test it?
Recorded a beautiful GIF for you!
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs