New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PreferenceKeys file to manage SharedPreferences keys. #891
Conversation
I think I've updated all the references of the keys. I've updated the PreferenceKeys with |
I'm not a huge fan of the comments so I'd prefer reverting it. Also bring your branch up-to-date with |
Completely missed some files, and PasswordStore.kt has a
|
Oh thanks, I'll revisit all the files again. IntelliJ's search results aren't that good when you have 100+ matching items. |
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
5bb53ea
to
848a142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
* develop: Scroll to files and enter folders when created (#909) Run a treewide reformat (#908) Improve how secrets and stored and used (#907) Improve and refactor Autofill heuristics (#905) Use PreferenceKeys file to manage SharedPreferences keys. (#891) Bump version Prepare release 1.9.2 update changelog Workaround to prevent crash on first run (#898) build: bump version Prepare release 1.9.1 Backport Actions fixes (#894) Remove API 30 from pull request test matrix (#879) CHANGELOG: reword to better clarify fixes Prevent cached passwords from being wiped (#884) Use remembered credential even if it is empty (#880) Reset SSH passphrase after SSH key import (#885) Add relnotes for #871 (#872) Add org.gnu.icecat as a trusted multi-origin browser (#871)
* develop: (62 commits) Scroll to files and enter folders when created (android-password-store#909) Run a treewide reformat (android-password-store#908) Improve how secrets and stored and used (android-password-store#907) Improve and refactor Autofill heuristics (android-password-store#905) Use PreferenceKeys file to manage SharedPreferences keys. (android-password-store#891) Revert "Support directly importing secrets" (android-password-store#904) Allow importing TOTP configuration through QR codes (android-password-store#903) Bump version Prepare release 1.9.2 update changelog Workaround to prevent crash on first run (android-password-store#898) Workaround to prevent crash on first run (android-password-store#898) Offer TOTP Autofill for OTP fields (android-password-store#899) Merge SshKeyGenFragment into its activity (android-password-store#897) Reintroduce TOTP support (android-password-store#890) Sync with release branch (android-password-store#896) build: bump version Prepare release 1.9.1 Backport Actions fixes (android-password-store#894) Rework GitHub Actions (android-password-store#893) ...
馃摙 Type of change
馃摐 Description
Let's just stop using raw strings :)
馃挕 Motivation and Context
Less chances of breaking code due to mistakes in typing strings again
馃挌 How did you test it?
Ran the app and changed a few settings. Still needs one more round of testing though.
馃摑 Checklist
馃敭 Next steps
Port viscerion's application preferences.
馃摳 Screenshots / GIFs