Improve and refactor Autofill heuristics #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for `AUTOFILL_HINT_NEW_PASSWORD` and
`AUTOFILL_HINT_NEW_USERNAME`. This allows apps to trigger a
`ClassifiedScenario` with only a generate password action and is the
analogue of the W3C new-password hint for websites.
* Do not consider HTML password fields without hints to be certain
password fields (they could contain e.g. bank account numbers,
API secrets,...).
* Reduce OTP field false positives by excluding the term "postal" as well
as fields that match the "code" heuristic term but have HTML maxLength
less than 6 or larger than 8.
* Add German heuristic term "einmal" ("one-time") for OTP fields
* Also exclude fields based on their HTML name (e.g. for terms such as
"search").
* Extract fieldId, hint and htmlName matches into an extension property.
* Reduce warnings and remove unnecessary suppression annotations.
msfjarvis
approved these changes
Jul 1, 2020
msfjarvis
added a commit
that referenced
this pull request
Jul 1, 2020
* develop: Scroll to files and enter folders when created (#909) Run a treewide reformat (#908) Improve how secrets and stored and used (#907) Improve and refactor Autofill heuristics (#905) Use PreferenceKeys file to manage SharedPreferences keys. (#891) Bump version Prepare release 1.9.2 update changelog Workaround to prevent crash on first run (#898) build: bump version Prepare release 1.9.1 Backport Actions fixes (#894) Remove API 30 from pull request test matrix (#879) CHANGELOG: reword to better clarify fixes Prevent cached passwords from being wiped (#884) Use remembered credential even if it is empty (#880) Reset SSH passphrase after SSH key import (#885) Add relnotes for #871 (#872) Add org.gnu.icecat as a trusted multi-origin browser (#871)
msfjarvis
added a commit
to fmeum/Android-Password-Store
that referenced
this pull request
Jul 1, 2020
* develop: (62 commits) Scroll to files and enter folders when created (android-password-store#909) Run a treewide reformat (android-password-store#908) Improve how secrets and stored and used (android-password-store#907) Improve and refactor Autofill heuristics (android-password-store#905) Use PreferenceKeys file to manage SharedPreferences keys. (android-password-store#891) Revert "Support directly importing secrets" (android-password-store#904) Allow importing TOTP configuration through QR codes (android-password-store#903) Bump version Prepare release 1.9.2 update changelog Workaround to prevent crash on first run (android-password-store#898) Workaround to prevent crash on first run (android-password-store#898) Offer TOTP Autofill for OTP fields (android-password-store#899) Merge SshKeyGenFragment into its activity (android-password-store#897) Reintroduce TOTP support (android-password-store#890) Sync with release branch (android-password-store#896) build: bump version Prepare release 1.9.1 Backport Actions fixes (android-password-store#894) Rework GitHub Actions (android-password-store#893) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
AUTOFILL_HINT_NEW_PASSWORDandAUTOFILL_HINT_NEW_USERNAME. This allows apps to trigger aClassifiedScenariowith only a generate password action and is theanalogue of the W3C new-password hint for websites.
password fields (they could contain e.g. bank account numbers,
API secrets,...).
as fields that match the "code" heuristic term but have HTML maxLength
less than 6 or larger than 8.
"search").
馃挕 Motivation and Context
馃挌 How did you test it?
Only lightly, but these kind of changes can only really be tested by snapshot users.
馃摑 Checklist
馃敭 Next steps
馃摳 Screenshots / GIFs