Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Migrate to the Compose gradle plugin #1354

Merged
merged 2 commits into from
May 29, 2024

Conversation

bentrengrove
Copy link
Member

@bentrengrove bentrengrove commented Apr 19, 2024

Migrate all samples to the compose gradle plugin and Kotlin 2.0

Also enable strong skipping mode on all samples

@bentrengrove bentrengrove changed the title [Draft] Migrate to the Compose gradle plugin [All] Migrate to the Compose gradle plugin May 26, 2024
@bentrengrove bentrengrove marked this pull request as ready for review May 26, 2024 22:13
@bentrengrove bentrengrove requested a review from a team as a code owner May 26, 2024 22:13
@bentrengrove bentrengrove merged commit 3960fde into main May 29, 2024
29 checks passed
@bentrengrove bentrengrove deleted the ben/compose_gradle_plugin branch May 29, 2024 22:20
@gastsail
Copy link

gastsail commented Jun 13, 2024

I have a question that I cannot find anywhere, is there anything we need to take care about regarding BOM and compose versions?

This is because now that the compiler comes with kotlin 2.0 I wonder if previous versions of BOM or compose components will crash since we are not specifying the right compiler version.

Example: I use an old version of BOM (2023.09.00) which have compose 1.5.1 (on which I need compiler 1.5.1 and kotlin 1.9.0) https://developer.android.com/jetpack/androidx/releases/compose-kotlin

Will I have any issues using old versions of compose libs without specifying anymore the right compiler?

Thanks

@bentrengrove
Copy link
Member Author

Compose library versions and Compose compiler versions are not linked, you can mix and match them. There is no need to match Compose 1.5.1 with Compiler 1.5.1

See this blog post for more details
https://android-developers.googleblog.com/2022/06/independent-versioning-of-Jetpack-Compose-libraries.html

@gastsail
Copy link

Compose library versions and Compose compiler versions are not linked, you can mix and match them. There is no need to match Compose 1.5.1 with Compiler 1.5.1

See this blog post for more details

https://android-developers.googleblog.com/2022/06/independent-versioning-of-Jetpack-Compose-libraries.html

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants