Remove desugaring from this project #1485
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
We can remove desugaring from this project.
The only usage of desugar API is just here.
nowinandroid/core/ui/src/main/kotlin/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt
Lines 242 to 247 in 85129e4
When we remove the desugaring, we can remove
![image](https://private-user-images.githubusercontent.com/48680511/335488611-e9fa227f-17e2-45fa-834e-6d78487efa79.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MDQ2NjUsIm5iZiI6MTcyNTYwNDM2NSwicGF0aCI6Ii80ODY4MDUxMS8zMzU0ODg2MTEtZTlmYTIyN2YtMTdlMi00NWZhLTgzNGUtNmQ3ODQ4N2VmYTc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA2MzI0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIyZmI5NDE4ZjQxYTlmOTEwYzUzZTZiMGFmYmJiYjNhM2E3M2Y5ODQyMTE1NjIzNWI2MDJhY2VkZmEyOGQ1ZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kFjT_RmZntlm8gWh471mnpFo2Nn8JUQGcjceG4r58Ko)
androidDesugarJdkLibs
dependency.Output APK's size is reduced 1MB.
And there's no need to use JAVA 11 whether even use the desugaring, the JAVA version bumped at #1392 PR